Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Resource azurerm_cosmosdb_gremlin_database #5248

Merged
merged 10 commits into from
Dec 26, 2019
Merged

New Resource azurerm_cosmosdb_gremlin_database #5248

merged 10 commits into from
Dec 26, 2019

Conversation

SebRosander
Copy link
Contributor

@SebRosander SebRosander commented Dec 25, 2019

Fixes some parts of #3692 and #4970

Tests passing:
=== RUN TestAccAzureRMCosmosGremlinDatabase_complete
=== PAUSE TestAccAzureRMCosmosGremlinDatabase_complete
=== CONT TestAccAzureRMCosmosGremlinDatabase_complete
--- PASS: TestAccAzureRMCosmosGremlinDatabase_complete (1160.85s)
PASS

=== RUN TestAccAzureRMCosmosGremlinDatabase_basic
=== PAUSE TestAccAzureRMCosmosGremlinDatabase_basic
=== CONT TestAccAzureRMCosmosGremlinDatabase_basic
--- PASS: TestAccAzureRMCosmosGremlinDatabase_basic (1097.21s)

@ghost ghost added the size/XL label Dec 25, 2019
@ghost ghost added the documentation label Dec 25, 2019
@SebRosander SebRosander marked this pull request as ready for review December 25, 2019 13:54
@SebRosander SebRosander changed the title [WIP] New Resource azurerm_cosmosdb_gremlin_database New Resource azurerm_cosmosdb_gremlin_database Dec 25, 2019
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @SebRosander,

thank you for the new resource! aside from a few minor comments i've left inline this is looking pretty good.

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the revisions @SebRosander! LGTM now 👍

@katbyte katbyte merged commit fac64c5 into hashicorp:master Dec 26, 2019
katbyte added a commit that referenced this pull request Dec 26, 2019
jackbatzner pushed a commit to jackbatzner/terraform-provider-azurerm that referenced this pull request Dec 31, 2019
jackbatzner pushed a commit to jackbatzner/terraform-provider-azurerm that referenced this pull request Dec 31, 2019
@ghost
Copy link

ghost commented Jan 8, 2020

This has been released in version 1.40.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 1.40.0"
}
# ... other configuration ...

@ghost ghost removed the waiting-response label Jan 8, 2020
@ghost
Copy link

ghost commented Mar 28, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants